[cfe-commits] r143790 - /cfe/trunk/lib/Analysis/LiveVariables.cpp

[Ted Kremenek]

The problem was that I was tired when I made that comment and misread the patch, so my comment made little sense.  As Anna pointed out, the dust eventually settled.

On Nov 5, 2011, at 7:50 AM, David Blaikie <dblaikie at gmail.com> wrote:

>>  I feel silly that I left out the "continue" statements.
> 
> I feel even more silly - I still don't see why the "continue"
> statements are necessary, could you explain (or Anna) explain it? If
> any of those blocks fire, they're the only thing in the loop so
> putting "continue" at the end of each seems like it wouldn't change
> the behavior at all. Or is this meant as some kind of future-proofing
> in case someone adds some non-conditional code to the end of the
> block? (pretty hard to speculate on whether such future use would want
> the continues or not, though, it seems to me)
> 
> If you are going to have the continues in, then you could remove all
> the elses, right?
> 
> if (...) {
>  ...
>  continue;
> }
> if (...) {
>  ...
>  continue;
> }
> ...
> break;