[cfe-commits] r143219 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprObjC.cpp test/SemaObjC/arc-objc-lifetime.m test/SemaObjC/arc-unavailable-for-weakref.m test/SemaObjCXX/arc-unavailable-for-weakref.mm

[John McCall]

On Oct 28, 2011, at 3:38 PM, jahanian wrote:
> On Oct 28, 2011, at 2:33 PM, John McCall wrote:
>> On Oct 28, 2011, at 1:06 PM, Fariborz Jahanian wrote:
>>> +    if ((castACTC == ACTC_retainable) && 
>>> +        isa<AttributedType>(castType) &&
>>> +        (castType.getObjCLifetime() !=  Qualifiers::OCL_None) &&
>>> +        (CCK == CCK_CStyleCast || CCK == CCK_OtherCast) &&
>> 
>> I don't think the CCK restriction is meaningful.
> 
> Need to check this. We will have:  CCK == CCK_ImplicitConversion
> In this test case:
> 
> void f8(const __strong id&);
> void test_f8() {
>   __strong id strong_id;
>   f8(strong_id);
> }

Ah, true.

John.