[cfe-commits] r142128 - /cfe/trunk/lib/Frontend/TextDiagnostic.cpp

[Abramo Bagnara]

Il 24/10/2011 20:54, Chandler Carruth ha scritto:
> On Sun, Oct 16, 2011 at 6:45 AM, Abramo Bagnara
> <abramo.bagnara at gmail.com <mailto:abramo.bagnara at gmail.com>> wrote:
> 
>     Can you write this as a public SourceManager method?
> 
> 
> I can, but what's the use case? I'd like to understand where else it's
> useful before adding it. It's a bit rough and ad-hoc to live in the
> SourceManager.

In our application we have the same need to show the name of the macro
that has expanded a given loc.

As I think this is common need I think that the right place for the
helper is in the public interface of SourceManager.

Do you see some drawback for that?