[cfe-commits] r142693 - in /cfe/trunk: lib/CodeGen/CGRTTI.cpp lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaDeclCXX.cpp test/CodeGenCXX/weak-extern-typeinfo.cpp

[jahanian]

On Oct 24, 2011, at 10:21 AM, Douglas Gregor wrote:

> 
> On Oct 21, 2011, at 3:27 PM, Fariborz Jahanian wrote:
> 
>> Author: fjahanian
>> Date: Fri Oct 21 17:27:12 2011
>> New Revision: 142693
>> 
>> 

>> 
>> Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=142693&r1=142692&r2=142693&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Sema/SemaDeclCXX.cpp (original)
>> +++ cfe/trunk/lib/Sema/SemaDeclCXX.cpp Fri Oct 21 17:27:12 2011
>> @@ -1151,6 +1151,10 @@
>>      // Okay, add this new base class.
>>      KnownBaseTypes[NewBaseType] = Bases[idx];
>>      Bases[NumGoodBases++] = Bases[idx];
>> +      if (const RecordType *Record = dyn_cast<RecordType>(NewBaseType))
> 
> Shouldn't this use NewBaseType->getAs<RecordType>()?

Sure. In r142807
- Fariborz

> 
> 	- Doug
>