[cfe-commits] [Patch] PR11179 - Update StmtPrinter to not complain on some IntegerLiteral types

[Douglas Gregor]

On Oct 20, 2011, at 5:36 PM, Chandler Carruth wrote:

> On Thu, Oct 20, 2011 at 5:12 PM, Richard Trieu <rtrieu at google.com> wrote:
> Should Clang be printing suffixes that are accepted only with certain flags?
> 
> I think this is an interesting policy decision. I'd love to hear Doug's thoughts on it.
> 
> It seems fine to me for Clang, when running with -fms-extensions, to suggest fixes even if only valid for -fms-extensions. Clearly if there is a generic suggestion that could be made, that would be a preferred alternative. For example, '__asm__' should be suggested before 'asm'.

I think it's fine for Clang to print suffixes that are only accepted with certain flags. Presumably, you should never get an IntegerLiteral of type __int128_t unless you're in a dialect that supports parsing it.

… except that we cheat when we're building template arguments, because it was convenient. That cheating could be eliminated by encoding integer literal values directly within SubstNonTypeTemplateParmExpr.

	- Doug

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111024/cde9d009/attachment.html>