[cfe-commits] PATCH: Switch libclang's formatDiagnostic routine to use the new TextDiagnostic interface

[Douglas Gregor]

Sent from my iPhone

On Oct 16, 2011, at 3:29 AM, Chandler Carruth <chandlerc at google.com> wrote:

> This patch switches libclang over to share the logic for emitting textual diagnostics with the Clang driver. There are some "interesting" ramifications of this switch:
> 
> - Complete path names to files instead of just filenames in some cases

Interesting. That's fine, since we're presumably matching the normal Clang behavior better. 

> - Macro backtrace notes are printed into the same blob of text

That's tricky. I think we'll want to provide separate API for this. Can you just turn off macro backtrace notes in libclang until we figure out that API. 

> - Possibility to extend with color, caret diagnostics, line-wrapping, etc
> 
And this part is great :)

Thanks for cleaning this up!

  - Doug