[cfe-commits] r142157 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaChecking.cpp lib/Sema/SemaType.cpp test/Sema/static-array.c

Peter Collingbourne peter at pcc.me.uk
Tue Oct 18 17:15:36 PDT 2011


On Sun, Oct 16, 2011 at 02:26:37PM -0700, Chandler Carruth wrote:
> On Sun, Oct 16, 2011 at 2:17 PM, Peter Collingbourne <peter at pcc.me.uk>wrote:
> 
> > +typedef int i3[static 3];
> 
> 
> I'm a bit sad that this is the test case lacking a note pointing to the
> static declaration, as it's the one where that note would be most useful.
> I'm imagining a note along the lines of:
> 
> 'callee parameter type defined with a static array size here'

While that would be nice, I think this is too much of an edge case to
deserve caring about too much.  The main purpose of that test case is
to ensure that we don't crash.  But feel free to add the diagnostic
yourself if you wish.

Thanks,
-- 
Peter



More information about the cfe-commits mailing list