[cfe-commits] r142109 - in /cfe/trunk: include/clang/Frontend/TextDiagnostic.h lib/Frontend/TextDiagnostic.cpp

[Chandler Carruth]

Author: chandlerc
Date: Sun Oct 16 01:24:58 2011
New Revision: 142109

URL: http://llvm.org/viewvc/llvm-project?rev=142109&view=rev
Log:
Add proper doxyments to the entry point routine, and remove a dead parameter.

Modified:
    cfe/trunk/include/clang/Frontend/TextDiagnostic.h
    cfe/trunk/lib/Frontend/TextDiagnostic.cpp

Modified: cfe/trunk/include/clang/Frontend/TextDiagnostic.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Frontend/TextDiagnostic.h?rev=142109&r1=142108&r2=142109&view=diff
==============================================================================
--- cfe/trunk/include/clang/Frontend/TextDiagnostic.h (original)
+++ cfe/trunk/include/clang/Frontend/TextDiagnostic.h Sun Oct 16 01:24:58 2011
@@ -72,10 +72,21 @@
                  const LangOptions &LangOpts,
                  const DiagnosticOptions &DiagOpts);
 
+  /// \brief Emit a textual diagnostic.
+  ///
+  /// This is the primary entry point for emitting textual diagnostic messages.
+  /// It handles formatting and printing the message as well as any ancillary
+  /// information needed based on macros whose expansions impact the
+  /// diagnostic.
+  ///
+  /// \param Loc The location for this caret.
+  /// \param Level The level of the diagnostic to be emitted.
+  /// \param Message The diagnostic message to emit.
+  /// \param Ranges The underlined ranges for this code snippet.
+  /// \param FixItHints The FixIt hints active for this diagnostic.
   void emitDiagnostic(SourceLocation Loc, DiagnosticsEngine::Level Level,
                       StringRef Message, ArrayRef<CharSourceRange> Ranges,
-                      ArrayRef<FixItHint> FixItHints,
-                      bool LastCaretDiagnosticWasNote = false);
+                      ArrayRef<FixItHint> FixItHints);
 
   /// \brief Print the diagonstic level to a raw_ostream.
   ///

Modified: cfe/trunk/lib/Frontend/TextDiagnostic.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/TextDiagnostic.cpp?rev=142109&r1=142108&r2=142109&view=diff
==============================================================================
--- cfe/trunk/lib/Frontend/TextDiagnostic.cpp (original)
+++ cfe/trunk/lib/Frontend/TextDiagnostic.cpp Sun Oct 16 01:24:58 2011
@@ -400,8 +400,7 @@
                                     DiagnosticsEngine::Level Level,
                                     StringRef Message,
                                     ArrayRef<CharSourceRange> Ranges,
-                                    ArrayRef<FixItHint> FixItHints,
-                                    bool LastCaretDiagnosticWasNote) {
+                                    ArrayRef<FixItHint> FixItHints) {
   PresumedLoc PLoc = getDiagnosticPresumedLoc(SM, Loc);
 
   // First, if this diagnostic is not in the main file, print out the