[cfe-commits] RFC: Half floating point support

Eli Friedman eli.friedman at gmail.com
Fri Oct 14 11:24:06 PDT 2011


On Fri, Oct 14, 2011 at 11:04 AM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:
> Hello John
>
>> This, and the analogous logic for parameters, should really be done in BuildFunctionType, or else it won't happen for function pointers/references, typedefs of function types, and templates that happen to instantiate argument or return types this way.  You should also ensure that the logic kicks in for unprototyped function types, which will require some special-case logic.
> BuildFunctionType seems to work only in C++ case, no? Right now it's
> called from 2 places only, one - in SemaTemplateDeduction.cpp and
> another one - from TreeTransform.h.
>
> It's never called on fp16-sema.c. Am I missing something?

No, you're not missing anything; John is describing how it should
work, you're describing how it actually does at the moment. :)

-Eli




More information about the cfe-commits mailing list