[cfe-commits] r141120 - /cfe/trunk/lib/Driver/ToolChains.cpp

Chandler Carruth chandlerc at gmail.com
Tue Oct 4 17:09:20 PDT 2011

On Tue, Oct 4, 2011 at 3:04 PM, Chandler Carruth <chandlerc at gmail.com>wrote:

> On Tue, Oct 4, 2011 at 2:42 PM, Chris Lattner <clattner at apple.com> wrote:
>> Hi Chandler, please split some of these quintuply nested loops out to a
>> helper function or two.  Thanks :)
> Yea, was planning on it... this whole thing just makes me sad....

Should be better with r141131 and r141134. Let me know if you'd like to see
more splits, these looked like a good balance between number of context
switches required while reading and terrible indentation and formatting due
to large functions.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111004/e5df0a6b/attachment.html>

More information about the cfe-commits mailing list