[cfe-commits] [LLVMdev] [cfe-dev] Unicode path handling on Windows

Nikola Smiljanic popizdeh at gmail.com
Tue Oct 4 05:35:02 PDT 2011


>
>
> +  for (int i = 0; i != argc; ++i)
> +  {
> +    // check lenght
>
> May want to correct the typo.
>
>
Fixed


>
> I think this should be formatted more like this to meet our coding
> standards (but am not 100% sure, so I will defer to others):
>
> if (ch < (UTF32)0x80)
>   bytesToWrite = 1;
> else if (ch < (UTF32)0x800)
>  bytesToWrite = 2;
> ...
> else
>  ch = UNI_REPLACEMENT_CHAR;
>
>
I haven't touched this code. I only took the function out of the section
that was commented out.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111004/84d54a66/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: application/octet-stream
Size: 15811 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111004/84d54a66/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.patch
Type: application/octet-stream
Size: 4685 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111004/84d54a66/attachment-0001.obj>


More information about the cfe-commits mailing list