[cfe-commits] r141073 - /cfe/trunk/lib/Driver/ToolChains.cpp
Chandler Carruth
chandlerc at gmail.com
Tue Oct 4 02:58:22 PDT 2011
Author: chandlerc
Date: Tue Oct 4 04:58:21 2011
New Revision: 141073
URL: http://llvm.org/viewvc/llvm-project?rev=141073&view=rev
Log:
Add a comment explaining that I have a better plan for implementing the
GCC installation search that requires fewer filesystem operations.
Planning to implement that next as the current approcah while thorough
(and so far looks correct) does a very unfortunate number of filesystem
operations.
I'm motivated to fix this in no small part because I would like to
support a much larger space of triples and GCC versions, which would
explode the current algorithm.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=141073&r1=141072&r2=141073&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/ToolChains.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains.cpp Tue Oct 4 04:58:21 2011
@@ -1605,6 +1605,8 @@
// accuracy, and architecture specificity in that order. The inverted walk
// requires testing the filesystem more times than is ideal, but shouldn't
// matter in practice as this is once on startup.
+ // FIXME: Instead of this, we should walk from the root down through each
+ // layer, and if it is "better" than prior installations found, use it.
static const char* GccVersions[] = {
"4.6.1", "4.6.0", "4.6",
"4.5.3", "4.5.2", "4.5.1", "4.5",
More information about the cfe-commits
mailing list