[cfe-commits] r141053 - in /cfe/trunk: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Tools.cpp

[Ted Kremenek]

Hi Chad,

I don't think that's the right fix.

The point of that test case is to catch adding warnings to clang that have no -W flag.  Per the big comment at the top of the file:

"(2) It prevents us adding new warnings to Clang that have no -W flag.  All
    new warnings should have -W flags.
    
    If you add a new warning without a flag, this test will fail.  To fix
    this test, simply add a warning group to that warning.

The list of warnings below should NEVER grow.  It should gradually shrink to 0."

Please revert your change and add a flag for this warning.

Thanks,
Ted

On Oct 3, 2011, at 9:46 PM, Chad Rosier wrote:

> Should be fixed with r141060.  Sorry for the breakage.
> 
> Chad
> 
> On Oct 3, 2011, at 8:21 PM, NAKAMURA Takumi wrote:
> 
>> FYI, diagtool list-warnings shows me;
>> 
>> Warnings with flags (355):
>> (snip)
>> Warnings without flags (305):
>> (snip)
>> 
>> STATISTICS:
>> 
>> Percentage of warnings with flags: 53.79%
>> Number of unique flags: 168
>> Average number of diagnostics per flag: 2.113
>> 
>> ******************** TEST 'Clang :: Misc/warning-flags.c' FAILED
>> ********************
>> Script:
>> --
>> diagtool list-warnings 2>&1 | FileCheck
>> /home/chapuni/bb/cmake-clang-x86_64-linux/llvm-project/clang/test/Misc/warning-flags.c
>> --
>> Exit Code: 1
>> Command Output (stderr):
>> --
>> /home/chapuni/bb/cmake-clang-x86_64-linux/llvm-project/clang/test/Misc/warning-flags.c:20:8:
>> error: expected string not found in input
>> CHECK: Warnings without flags (304):
>>      ^
>> <stdin>:1:1: note: scanning from here
>> Warnings with flags (355):
>> ^
>> --
>> 
>> ********************
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits