[cfe-commits] PATCH: Make DiagnoseInvalidRedeclaration state when a member decl does not match due to "const" mismatch (issue 5167048)
Eli Friedman
eli.friedman at gmail.com
Fri Sep 30 16:39:36 PDT 2011
On Fri, Sep 30, 2011 at 4:12 PM, <rikka at google.com> wrote:
> Reviewers: chandlerc,
>
>
>
> Please review this at http://codereview.appspot.com/5167048/
>
> Affected files:
> M include/clang/Basic/DiagnosticSemaKinds.td
> M lib/Sema/SemaDecl.cpp
> M test/SemaCXX/function-redecl.cpp
> M test/SemaCXX/nested-name-spec.cpp
I don't really like the wording "member declaration has const
keyword"; there is no guarantee that the note points anywhere near the
keyword "const", and you've lost the "nearly matches" part of the
original diagnostic. Maybe something more like "member declaration
does not match because it is const qualified"?
The code looks fine.
-Eli
More information about the cfe-commits
mailing list