[cfe-commits] Fix for Bug 10978

Ruben Van Boxem vanboxem.ruben at gmail.com
Fri Sep 30 11:51:23 PDT 2011


2011/9/30 Eli Friedman <eli.friedman at gmail.com>

> On Fri, Sep 30, 2011 at 2:44 AM, Ruben Van Boxem
> <vanboxem.ruben at gmail.com> wrote:
> > http://llvm.org/bugs/show_bug.cgi?id=10978
> >
> > Attached is a revised patch that also uses X86AttributesSema for x86_64,
> and
> > rejects the force_align_arg_pointer attribute for x86_64.
> >
> > The testcase is just a copy of the existing dllimport-dllexport test, but
> I
> > modified the triple used. I hope this is correct, otherwise, please show
> me
> > how cause I don't know how to set the test options.
>
> You can just run the existing test with multiple triples; multiple RUN
> lines work the way you would expect.
>

Fixed.


>
> @@ -257,21 +258,20 @@ namespace {
>     }
>   };
>  }
> -
>  const TargetAttributesSema &Sema::getTargetAttributesSema() const {
>   if (TheTargetAttributesSema)
>     return *TheTargetAttributesSema;
>
> Random whitespace change?
>

Yes it is, fixed.

Ruben
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110930/716bd320/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x86_64.patch
Type: application/octet-stream
Size: 1850 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110930/716bd320/attachment.obj>


More information about the cfe-commits mailing list