[cfe-commits] Patch for clang Makefile

Douglas Gregor dgregor at apple.com
Tue Sep 27 14:30:06 PDT 2011


On Sep 27, 2011, at 1:49 PM, Greg Clayton wrote:

> Here is a patch for the clang Makefile. If you download clang and delete the test directory, you can end up with the copy line failing with an error, yet the make will complete successfully. It confuses Xcode when the make is invoked in an Xcode project. I tried submitting but got an error. If anyone can submit this for me, that would be great.
> 
> 
> Index: Makefile
> ===================================================================
> --- Makefile	(revision 140631)
> +++ Makefile	(working copy)
> @@ -68,7 +68,7 @@
> ifneq ($(PROJ_SRC_ROOT),$(PROJ_OBJ_ROOT))
> $(RecursiveTargets)::
> 	$(Verb) for dir in test unittests; do \
> -	  if [ ! -f $${dir}/Makefile ]; then \
> +	  if [ -f $(PROJ_SRC_DIR)/$${dir}/Makefile ] && [ ! -f $${dir}/Makefile ]; then \
> 	    $(MKDIR) $${dir}; \
> 	    $(CP) $(PROJ_SRC_DIR)/$${dir}/Makefile $${dir}/Makefile; \
> 	  fi \

Committed as r140639, thanks!

	- Doug



More information about the cfe-commits mailing list