[cfe-commits] [cfe-dev] [OpenCL patch] Vector literals are rvalues
Tobias Grosser
grosser at fim.uni-passau.de
Wed Sep 21 06:37:01 PDT 2011
Hi Anton,
please submit patches to cfe-commits.
On 09/21/2011 02:16 PM, Anton Lokhmotov wrote:
> Clang currently accepts taking the address of a vector literal in the OpenCL
> mode, e.g.
>
> return&((int4)(3,2,1,0)); // expected-error{{address expression must be
> an lvalue}}
>
> which is wrong (http://llvm.org/bugs/show_bug.cgi?id=10966).
>
> Please review the attached patch that fixes this problem.
I already reviewed the patch in Bugzilla. This updated patch fixed the
remaining style comment I had.
As I am new to the clang OpenCL implementation, an additional review
would be great.
Tobi
More information about the cfe-commits
mailing list