[cfe-commits] r140068 - in /cfe/trunk: include/clang/AST/Decl.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/Specifiers.h lib/AST/Decl.cpp lib/AST/DeclPrinter.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGe

David Blaikie dblaikie at gmail.com
Mon Sep 19 14:37:59 PDT 2011


>
> We generally prefer llvm_unreachable to assert(0)
>

we do (specifically just clang, or llvm as a whole)? I've seen some
variation in this & when someone was fixing up the assert("foo")s in the
code to assert(0 && "foo")s a week or two ago I thought about suggesting
they be llvm_unreachables instead, but when I searched I think I found an
email by Chris Lattner saying that assert(0 && "foo") was preferred (I can
see if I can find it again).

Is there some consistent policy/documentation on this?

- David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110919/b74d5a73/attachment.html>


More information about the cfe-commits mailing list