[cfe-commits] [Patch] Fix regression in digraph fix-it hint

[Richard Trieu]

Committed r140039

On Fri, Sep 16, 2011 at 9:20 PM, Douglas Gregor <dgregor at apple.com> wrote:
>
> On Sep 16, 2011, at 8:38 PM, Richard Trieu wrote:
>
>> Changes to the name lookup have caused a regression in the digraph fix-it hint.
>> For instance:
>>
>> template <class T> void E() {};
>> class F {};
>>
>> void test() {
>>  ::E<::F>();
>>  E<::F>();
>> }
>>
>> Gives the following error messages:
>>
>> error: found '<::' after a template name which forms the
>>      digraph '<:' (aka '[') and a ':', did you mean '< ::'?
>>  ::E<::F>();
>>     ^~~
>>     < ::
>> error: expected expression
>>  E<::F>();
>>     ^
>> error: expected ']'
>> note: to match this '['
>>  E<::F>();
>>
>> This patch adds the digraph fix-it check right before the name lookup,
>> moves the shared checking code to a new function, and adds new
>> tests to catch future regressions.
>
> Looks good, thanks!
>
>        - Doug
>
>