[cfe-commits] [PATCH] Using proper file mode for -E

Aaron Ballman aaron at aaronballman.com
Sun Sep 18 07:46:33 PDT 2011


This is a fix for Bug 6870.

On Windows, we really do want CRLFs to remain, otherwise the output
ends up looking incredibly bad when piped to a file (even though it
looks fine on the command prompt).  For instance:

clang.exe -E some_file.cpp > test.txt

With Unix line endings, that will produce output which appears all in
a single line in some text editors (such as notepad).  Such as:

#line 1 "some_file.cpp" #line 1 "some_file.cpp" #line 1 "<built-in>"
#line 1 "<built-in>" #line 138 "<built-in>" #line 1 "<command line>"
#line 1
and so on...

But with CRLFs, the output ends up looking fine:
#line 1 "some_file.cpp"
#line 1 "some_file.cpp"
#line 1 "<built-in>"
#line 1 "<built-in>"
#line 138 "<built-in>"
#line 1 "<command line>"
#line 1

~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OptELineEndings.diff
Type: application/octet-stream
Size: 846 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110918/49399dc0/attachment.obj>


More information about the cfe-commits mailing list