[cfe-commits] r139332 - in /cfe/trunk: lib/Headers/limits.h test/Headers/wchar_limits.cpp

[Eric Christopher]

On Sep 16, 2011, at 5:31 PM, Bob Wilson wrote:

> This is basically just a revert of Sean Hunt's change 135455, but you did not remove the addition of __WCHAR_UNSIGNED__.  That macro is now only used in a test.  If we're not keeping the rest of that change, we should drop the unused macro as well.
> 

Yeah. We should use it to conditionalize.

> Sean, can you clarify what problem you were trying to solve with that change?  The commit message was:
> 
> "Implement a __WCHAR_UNSIGNED__ macro and use it to include WCHAR_MIN and
> WCHAR_MAX in limits.h, thus solving the problem where the system header
> thinks it knows better."


Sean? I'm pretty sure this can't be correct.

-eric