[cfe-commits] Null init suggestion

David Blaikie dblaikie at gmail.com
Fri Sep 9 22:37:37 PDT 2011


On Fri, Sep 9, 2011 at 7:46 AM, Douglas Gregor <dgregor at apple.com> wrote:

>
> On Sep 9, 2011, at 12:19 AM, David Blaikie wrote:
>
> I like the direction of this patch, but I think that the note text used
>> here
>>
>> note: add initialization to silence this warning
>>
>> isn't very helpful. If we're only going to print one note, I'd rather it
>> say something like
>>
>> note: initialize the variable 'x' to silence this warning
>>
>
> Changed to use this suggested diagnostic message.
>
>
> Looks good! Please go ahead and commit.
>

Thanks Doug, committed as 139463 (had myself a little confused about what I
named that patch file when I sent it for review - been juggling things
around a little too much recently)

- David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110909/d8d35acb/attachment.html>


More information about the cfe-commits mailing list