[cfe-commits] [PATCH] Extend lexical scope of attributes to include function parameters.

Douglas Gregor dgregor at apple.com
Wed Sep 7 15:35:00 PDT 2011


Looks great!

	- Doug

On Sep 7, 2011, at 3:19 PM, Delesley Hutchins wrote:

> Updated patch:
> 
>  http://codereview.appspot.com/4993045/
> 
>> Well… okay, if we have to check in the parser whether we have a function, please use
>> Decl::isFunctionOrFunctionTemplate() and handle the function-template case.
> 
> An excellent point!  Done.
> 
>> How about naming these EnterDelayedFunctionContext and ExitDelayedFunctionContext?
> 
> I renamed these ActOnReenterFunctionContext, to match
> ActOnReenterTemplateScope,
> which does something very similar.
> 
>  -DeLesley
> 
> -- 
> DeLesley Hutchins | Software Engineer | delesley at google.com | 505-206-0315
> <function_parameter_parsing4.patch>





More information about the cfe-commits mailing list