[cfe-commits] r139217 - in /cfe/trunk: include/clang/Frontend/TextDiagnosticPrinter.h lib/Frontend/TextDiagnosticPrinter.cpp

[Chandler Carruth]

On Tue, Sep 6, 2011 at 6:53 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

> On Sep 6, 2011, at 6:47 PM, Chandler Carruth wrote:
>
> > Author: chandlerc
> > Date: Tue Sep  6 20:47:09 2011
> > New Revision: 139217
> >
> > -  void EmitCaretDiagnostic(SourceLocation Loc, CharSourceRange *Ranges,
> > -                           unsigned NumRanges, const SourceManager &SM,
> > +  void EmitCaretDiagnostic(SourceLocation Loc,
> > +                           SmallVectorImpl<CharSourceRange> &Ranges,
>
> Should this be an ArrayRef too?
>

I *really* wanted it to be one. Sadly, we mutate the source ranges as part
of the recursive walk through the macro expansions. =[ I'll look into
whether we can do that on the stack as copies eventually; I'm hoping to
isolate that recursive walk more before I start messing with it
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110906/4ef82e38/attachment.html>