[cfe-commits] [PATCH] Add the resource directory to the search path for Driver::GetFilePath
Peter Collingbourne
peter at pcc.me.uk
Mon Sep 5 19:12:32 PDT 2011
On Mon, Sep 05, 2011 at 06:17:38PM -0400, Rafael Ávila de Espíndola wrote:
> >> I think it is OK. I know it is hard to test the driver, but for this
> >> patch we might be able to check that there is as "/clang/" in the output
> >> of -print-file-name=include, no?
> >
> > What if the user has configured clang with a custom resource directory
> > (i.e. using --with-clang-resource-dir)? I can't see a reliable way
> > of extracting the resource directory from the driver, and I don't know
> > if it's worth adding one just for the sake of this test.
>
> That is true. I had forgot that it was configurable. I think the patch is OK as is then.
r139127.
Thanks,
--
Peter
More information about the cfe-commits
mailing list