[cfe-commits] PATCH: Restart handling of a function declarator if the function name was typo-corrected (issue 4929043)

Kaelyn Uhrain rikka at google.com
Tue Aug 30 16:26:48 PDT 2011

Since trying to refactor Sema::ActOnFunctionDeclarator has proved to be far
more time consuming and invasive (lots of state needed throughout the func
spread among multiple variables with far too many order-dependent calls to
other complex functions that depend heavily on side-effects), I've updated
the current fix for DiganoseInvalidRedeclaration typo correction to pack the
extra args needed to call Sema::ActOnFunctionDeclarator into a struct. And
yes, I suspect the run-on sentence complete with tangents is a symptom of
spending so much time digging around in and trying to untangle

The updated patch is attached, as rietveld is still too lame to send out an
email with a patch or any kind of description when using its upload.py
script to update an existing issue with a new patchset.


On Tue, Aug 30, 2011 at 4:16 PM, <rikka at google.com> wrote:

> http://codereview.appspot.com/**4929043/<http://codereview.appspot.com/4929043/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110830/84212106/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: function-redecl-typo-correction-fix.diff
Type: text/x-diff
Size: 11008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110830/84212106/attachment.diff>

More information about the cfe-commits mailing list