[cfe-commits] [patch] warn on missing [super finalize] call
fjahanian at apple.com
Sun Aug 28 11:58:35 PDT 2011
LGTM. I am not sure though that this warning, like the other one, makes any sense in arc mode.
You may want to turn it off in arc mode.
On Aug 28, 2011, at 2:58 AM, Nico Weber wrote:
> the attached patch makes clang warn on missing [super finalize] calls.
> The warning uses the same logic as gcc (
> http://codesearch.google.com/#N01oSP8jpDo/gcc/objc/objc-act.c , search
> for "should_call_super_finalize" in that file). This is half of
> This follows Fariborz' advice from
> . I added OMF_finalize to a few switch statements, mostly to fix
> "unhandled value in switch" warnings – I tried to add it so that it
> didn't change the previous semantics.
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
More information about the cfe-commits