[cfe-commits] [PATCH] Various minor bug fixes to thread-safety analysis.

[Ted Kremenek]

This looks good to me.

On Aug 26, 2011, at 2:21 PM, Delesley Hutchins wrote:

> This patch fixes several bugs in the recently-added thread safety
> analysis, so that clang can be used to build itself with either
> -Wthread-safety or -Weverything enabled.  This patch has been code
> reviewed by Chandler Carruth and Jeffrey Yasskin; prior comments can
> be found at:
> 
> http://codereview.appspot.com/4942055/
> 
> I have added regression tests for the troublesome cases to
> test/SemaCXX/warn-thread-safety-parsing.cpp.  Note that in two cases,
> there may be a possible bug in the clang AST.  I have marked these two
> cases with a FIXME comment in the patch -- perhaps someone with
> greater knowledge in this area can let me know if I have encountered a
> bug or if the behavior is expected.
> 
>  -DeLesley
> 
> -- 
> DeLesley Hutchins | Software Engineer | delesley at google.com | 505-206-0315
> <various_bug_fixes2f.patch>