[cfe-commits] r138638 - /cfe/trunk/lib/Sema/SemaExpr.cpp
John McCall
rjmccall at apple.com
Fri Aug 26 11:41:18 PDT 2011
Author: rjmccall
Date: Fri Aug 26 13:41:18 2011
New Revision: 138638
URL: http://llvm.org/viewvc/llvm-project?rev=138638&view=rev
Log:
In -Wno-error=non-pod-varargs, initialize a temporary with
the crazy comma expression so that we get an r-value in the
varargs position.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=138638&r1=138637&r2=138638&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Fri Aug 26 13:41:18 2011
@@ -517,9 +517,18 @@
ExprResult Comma = ActOnBinOp(TUScope, E->getLocStart(), tok::comma,
Call.get(), E);
if (Comma.isInvalid())
- return ExprError();
-
+ return ExprError();
E = Comma.get();
+
+ // Use that to initialize a temporary, or else we might get an
+ // l-value in a varargs position.
+ ExprResult Temp = PerformCopyInitialization(
+ InitializedEntity::InitializeTemporary(E->getType()),
+ E->getLocStart(),
+ Owned(E));
+ if (Temp.isInvalid())
+ return ExprError();
+ E = Temp.get();
}
}
More information about the cfe-commits
mailing list