[cfe-commits] [PATCH]PNaClTargetInfo: add __ELF__, _REENTRANT and _GNU_SOURCE defines and update the test.

Ivan Krasin krasin at chromium.org
Thu Aug 25 16:52:36 PDT 2011

On Thu, Aug 25, 2011 at 4:45 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Thu, Aug 25, 2011 at 4:16 PM, Ivan Krasin <krasin at chromium.org> wrote:
>> Hi Clang team!
>> This patch adds few missing defines to PNaClTargetInfo to make clang++
>> work correctly on #include <stdio.h> and similar cases. I've updated
>> that test to check that these defines are there and that it can
>> #include <stdio.h>
>> The patch is attached and is also available online:
>> http://codereview.chromium.org/7748035/
>> Please, let me know if it's fine to commit.
> Putting "#include <stdio.h>" into a test is likely to explode... but
> otherwise, fine.
Thanks Eli! Landed as r138607 (#include <stdio.h> is removed)
btw, I also was not sure that putting it into the test is a good idea.
In fact, the first patch here does not contain it:

Ivan Krasin

More information about the cfe-commits mailing list