[cfe-commits] BCPL comments not recognized when computing preamble
kyrtzidis at apple.com
Thu Aug 25 13:40:58 PDT 2011
In r138580, thanks!
On Aug 25, 2011, at 1:05 AM, Matthias Kleine wrote:
> On Aug 24, 2011, at 7:17 PM, Argyrios Kyrtzidis wrote:
>> On Aug 24, 2011, at 9:21 AM, Matthias Kleine wrote:
>>> Is there any reason Lexer::ComputePreamble does not take external LangOptions into account, but uses default-constructed ones? As a result, source files that start with BCPL-comments are recognized as having no preambles, even if the file's language supports such comments.
>>> Would the attached patch solve the problem?
>> Look good, could you also please add a test case as well ?
> I extended an existing preamble-test to reproduce the failing behavior. Here's a patch.
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
More information about the cfe-commits