[cfe-commits] Threadsafety-- basic lockset implementation

Ted Kremenek kremenek at apple.com
Tue Aug 23 16:46:06 PDT 2011

On Aug 23, 2011, at 4:31 PM, Caitlin Sadowski wrote:

>> This checker is also getting pretty big.  Generally speaking AnalysisBasedWarnings.cpp should only contain the "top-level" logic for driving analyses.  The analyses themselves should be in a separate file and activated via a small API.  When you get a chance, please move the bulk of the logic to libAnalysis, and have AnalysisBasedWarnings.cpp just call the entry point.
> Ok, sounds good! I will do this soon.

Thanks so much!

The silver lining of moving it to libAnalysis is that it cleanly decouples the policy of issuing warnings from the analysis itself.  That allows the analysis to be (potentially) reused in different contexts.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110823/d14e876f/attachment.html>

More information about the cfe-commits mailing list