[cfe-commits] [patch] Warn on missing [super dealloc] call

[jahanian]

On Aug 21, 2011, at 4:54 PM, Nico Weber wrote:

> Hi,
> 
> the attached patch makes clang warn on missing [super dealloc] calls.
> The warning uses the same logic as gcc (
> http://codesearch.google.com/#N01oSP8jpDo/gcc/objc/objc-act.c , search
> for "should_call_super_dealloc" in that file). This is half of
> PR10661.
> 
> Ok?

OK.

> 
> For completeness, I'd like to do the same for -finalize (gcc does, too
> – "should_call_super_finalize" in the file above). Would you prefer if
> I added OMF_finalize to the getMethodFamily() return type enum, or
> should I check for the literal "finalize" at the places where this
> patch calls getMethodFamily()? -finalize is a "special" method, so
> adding it to OMF is arguable ok, but garbage collection seems on the
> way out. Please let me know.

We now follow this convention of naming OMF_xxx regardless of memory model.

- Fariborz

> 
> Nico
> <missing-dealloc.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits