[cfe-commits] r138220 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/CFRefCount.cpp lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp lib/StaticAnalyzer/Core/ExprEngineObjC.cpp

[Jordy Rose]

This is running a Debug build and watching the total time of the run, without attempting to quiet the rest of my system -- in other words, entirely anecdotal. I feel like the total time has crept up by a second or so, though.

Also, iterators.cpp takes a LONG time (before and after this change). That might be a good place to look for optimization opportunities?


On Aug 21, 2011, at 17:48, Ted Kremenek wrote:

> Was the performance hit observable?  If so, what are you seeing?  Why do you think there is a performance hit?
> 
> On Aug 21, 2011, at 12:41 PM, Jordy Rose <jediknil at belkadan.com> wrote:
> 
>> Author: jrose
>> Date: Sun Aug 21 14:41:36 2011
>> New Revision: 138220
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=138220&view=rev
>> Log:
>> [analyzer] Migrate return value handling from CFRefCount to ExprEngine. This seems to result in a minor performance hit, but I think that will go away again once we eliminate TransferFuncs from function calls entirely.
>> 
>> Modified:
>>   cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
>>   cfe/trunk/lib/StaticAnalyzer/Core/CFRefCount.cpp
>>   cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp
>>   cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp