[cfe-commits] r137763 - /cfe/trunk/test/CodeGenCXX/weak-external.cpp

Eric Christopher echristo at apple.com
Wed Aug 17 10:33:39 PDT 2011


On Aug 17, 2011, at 10:30 AM, Chris Lattner wrote:

> 
> On Aug 16, 2011, at 4:04 PM, Eric Christopher wrote:
> 
>> 
>> On Aug 16, 2011, at 3:13 PM, Eric Christopher wrote:
>> 
>>> 
>>> On Aug 16, 2011, at 3:12 PM, Eli Friedman wrote:
>>> 
>>>> We generally try to avoid having clang tests include standard headers...
>>> 
>>> Ah crap. Thanks, completely forgot. Though it makes c++ tests somewhat harder :)
>> 
>> I let delta chew on the preprocessed file for a while and the result is still somewhat unsatisfactory. There are some other test cases in that directory that include headers so I'm likely to let it go for now.
> 
> If any of these tests are particularly difficult to migrate, feel free to just nuke them.  A lot of the old ones in particular aren't worth fighting for.

Ah sweet. That'll make it much easier. I've been trying to make the ones that really test the optimizer into optimizer tests etc.

-eric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110817/44a51bdc/attachment.html>


More information about the cfe-commits mailing list