[cfe-commits] r133708 strikes me again? - the case clang stalls

[John McCall]

On Aug 9, 2011, at 3:44 AM, Jay Foad wrote:
> On 9 August 2011 11:40, Jay Foad <jay.foad at gmail.com> wrote:
>> On 9 August 2011 06:58, John McCall <rjmccall at apple.com> wrote:
>>> I think your patch to LLVM is a good idea;  replaceAllUsesWith should
>>> not be assuming a fully-formed AST.  As a slight optimization, I would
>>> suggest doing this instead:
>>>  if (Succ->empty()) continue;
>>> Jay, does that seem reasonable?
>> 
>> Sure, I'm fine with either your or Takumi's fix. Thanks for taking the
>> time to investigate.
> 
> Hang on... if we need to cope with half-baked IR, won't your fix still
> fall over on a BB that contains some phi nodes but nothing else?

Ah, yes, that's true;  good catch.  Clang (and frontends in general) are
much less likely to generate such code, but that's not a good reason
for replaceAllUsesWith to fall over.

John.