[cfe-commits] r137107 - /cfe/trunk/tools/CMakeLists.txt

Ted Kremenek kremenek at apple.com
Tue Aug 9 07:36:37 PDT 2011


Thanks Doug.  That wasn't at all clear from looking at this file.  It just looked like a jumble of entries.  Sorting it made it clear to me what was actually being included in the build.  I'm fine with changing it back.

Out of curiosity, does changing the order here functionally make any difference?  Doesn't the dependency analysis ultimately determine the order in which things are built?

Sent from my iPad

On Aug 9, 2011, at 6:47 AM, Douglas Gregor <dgregor at apple.com> wrote:

> 
> 
> Sent from my iPhone
> 
> On Aug 8, 2011, at 8:39 PM, Ted Kremenek <kremenek at apple.com> wrote:
> 
>> Author: kremenek
>> Date: Mon Aug  8 22:39:10 2011
>> New Revision: 137107
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=137107&view=rev
>> Log:
>> Sort CMakeLists.txt.
>> 
>> Modified:
>>   cfe/trunk/tools/CMakeLists.txt
>> 
>> Modified: cfe/trunk/tools/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/CMakeLists.txt?rev=137107&r1=137106&r2=137107&view=diff
>> ==============================================================================
>> --- cfe/trunk/tools/CMakeLists.txt (original)
>> +++ cfe/trunk/tools/CMakeLists.txt Mon Aug  8 22:39:10 2011
>> @@ -1,5 +1,5 @@
>> -add_subdirectory(libclang)
>> -add_subdirectory(c-index-test)
>> add_subdirectory(arcmt-test)
>> add_subdirectory(c-arcmt-test)
>> +add_subdirectory(c-index-test)
>> add_subdirectory(driver)
>> +add_subdirectory(libclang)
> 
> We typically like to have libraries come before the executables that link against them.



More information about the cfe-commits mailing list