[cfe-commits] [cfe-dev] Proposal for thread safety attributes for Clang

Douglas Gregor dgregor at apple.com
Sat Aug 6 13:09:32 PDT 2011

On Aug 5, 2011, at 2:24 PM, Caitlin Sadowski wrote:

> Doug,
> Thanks for reviewing the patch! Here is an updated patch, with
> comments inline. Let me know if it is ok to submit, or if you have any
> other edits.

+      if (ArgExpr.isInvalid()) {
+        ArgExprsOk = false;
+        SkipUntil(tok::r_paren);

Wouldn't MatchRHSPunctuation provide better recovery diagnostics?

This looks fine to commit.

	- Doug

More information about the cfe-commits mailing list