[cfe-commits] r136927 - in /cfe/trunk: include/clang/Basic/IdentifierTable.h include/clang/Sema/Sema.h lib/Sema/SemaDeclObjC.cpp test/SemaObjC/class-protocol-method-match.m test/SemaObjC/qualified-protocol-method-conflicts.m

[Ted Kremenek]

Agreed.  I've reverted both.

On Aug 5, 2011, at 4:05 PM, Chris Lattner wrote:

> 
> On Aug 5, 2011, at 2:56 PM, Ted Kremenek wrote:
> 
>> I have disabled the test in r136984 until Fariborz has a chance to look at this when he gets back from vacation.
> 
> Thanks, but I think the whole patch should be reverted for now.  The test being nondeterminstic is just a symptom of the compiler being non-deterministic.  Disabling the test fixes the former but not the later problem.
> 
> -Chris
> 
>> 
>> On Aug 5, 2011, at 10:05 AM, Chris Lattner wrote:
>> 
>>> 
>>> On Aug 5, 2011, at 8:44 AM, Fariborz Jahanian wrote:
>>> 
>>>> Warnings on windows are correct but in different order. It has to do with sorting of selectors based on
>>>> their unique pointer. I requested Ted. to make the test Darwin only for now.
>>> 
>>> Hi Fariborz,
>>> 
>>> That isn't a good enough solution.  Pointers can be arbitrarily ordered even on Darwin.  Please make the diagnostics come out in a deterministic order somehow.
>>> 
>>> -Chris
>>> 
>>>> 
>>>> - Fariborz
>>>> 
>>>> On Aug 4, 2011, at 8:39 PM, NAKAMURA Takumi wrote:
>>>> 
>>>>> 2011/8/5 Fariborz Jahanian <fjahanian at apple.com>:
>>>>>> Author: fjahanian
>>>>>> Date: Thu Aug  4 16:28:44 2011
>>>>>> New Revision: 136927
>>>>>> 
>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=136927&view=rev
>>>>>> Log:
>>>>>> objective-c: diagnose protocol inconsistencies in following
>>>>>> situation. When a class explicitly or implicitly (through inheritance)
>>>>>> "conformsTo" two protocols which conflict (have methods which conflict).
>>>>>> This is 2nd part of // rdar://6191214.
>>>>>> 
>>>>>> Added:
>>>>>> cfe/trunk/test/SemaObjC/qualified-protocol-method-conflicts.m
>>>>>> Modified:
>>>>>> cfe/trunk/include/clang/Basic/IdentifierTable.h
>>>>>> cfe/trunk/include/clang/Sema/Sema.h
>>>>>> cfe/trunk/lib/Sema/SemaDeclObjC.cpp
>>>>>> cfe/trunk/test/SemaObjC/class-protocol-method-match.m
>>>>> 
>>>>> Too weird, I have seen warnings in different order with
>>>>> class-protocol-method-match.m on msvc10 and mingw32.
>>>>> It is not affected by -triple.
>>>>> 
>>>>> The log attached. (w/o -verify)
>>>>> 
>>>>> ...Takumi
>>>>> <mingw.txt>
>>>> 
>>>> _______________________________________________
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>> 
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> 
>