[cfe-commits] [libcxx] r136576 - /libcxx/trunk/include/__hash_table

Chandler Carruth chandlerc at gmail.com
Sat Jul 30 14:10:16 PDT 2011


Author: chandlerc
Date: Sat Jul 30 16:10:16 2011
New Revision: 136576

URL: http://llvm.org/viewvc/llvm-project?rev=136576&view=rev
Log:
Revert r136546, which was submitted without review.

Original change:
Destruct elements of hash tables when removing individual entries from
the hash_table. I think this is the correct solution to PR10507, but I'm
not sure since this is a little bit cargo-culted. Howard, please review.

Modified:
    libcxx/trunk/include/__hash_table

Modified: libcxx/trunk/include/__hash_table
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__hash_table?rev=136576&r1=136575&r2=136576&view=diff
==============================================================================
--- libcxx/trunk/include/__hash_table (original)
+++ libcxx/trunk/include/__hash_table Sat Jul 30 16:10:16 2011
@@ -1726,7 +1726,6 @@
 typename __hash_table<_Tp, _Hash, _Equal, _Alloc>::__node_holder
 __hash_table<_Tp, _Hash, _Equal, _Alloc>::remove(const_iterator __p) _NOEXCEPT
 {
-    __node_traits::destroy(__node_alloc(), __p.operator->());
     // current node
     __node_pointer __cn = const_cast<__node_pointer>(__p.__node_);
     size_type __bc = bucket_count();





More information about the cfe-commits mailing list