[cfe-commits] [cfe-dev] Proposal for thread safety attributes for Clang

[Caitlin Sadowski]

First patch has been committed. Let me know if you had something
different in mind for the documentation. The second patch is attached
for review, also available at http://codereview.appspot.com/4707044.

Cheers,

Caitlin

On Fri, Jul 22, 2011 at 3:05 PM, Caitlin Sadowski <supertri at google.com> wrote:
>> By "static analysis-based warnings layer" are you referring to Sema's
>> CFG-base warnings, or a new checker for the static analyzer?
>
> We are currently implementing the existing GCC checks with Sema's
> CFG-based warnings. Future warnings and checks (e.g. which we do not
> have a large amount of previous experience using) will start as
> checkers in the static analyzer while they are being evaluated (and
> only migrate into the compiler proper upon consensus).
>
>> Your first patch is fine to commit, with one addition: please also provide
>> documentation for the attributes you're adding (it's fine for it to be based
>> on the text in the C/C++ Thread Safety Annotations doc. you link to above),
>
> Great! Thanks!
>
> Cheers,
>
> Caitlin Sadowski
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: threadsafety_parsing_remainingattrs.patch
Type: text/x-patch
Size: 44949 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110728/c91cc2e1/attachment.bin>