[cfe-commits] [Patch][Review] Tests for explicit conversion operators

Douglas Gregor dgregor at apple.com
Sat Jul 23 12:00:35 PDT 2011


On Jul 23, 2011, at 10:26 AM, Jonathan Sauer wrote:

> Hello,
> 
>> as promised in an earlier mail, I wrote some more tests for C++0x's explicit conversion operators (and
>> found a clang bug along the way, PR10453). I think they are complete now (except for the interaction with
>> constexpr, which is not implemented yet as far as I know).
>> 
>> I tried to follow the other tests, although I'm not sure about two points:
>> 
>> 1. LLVM's coding guidelines state that lines must remain below 80 characters. This does not seem to be
>>  followed in clang's tests, so I didn't, either.
>> 2. I added the FDIS section numbers corresponding to the tests as comments which I think makes following
>>  them easier. OTOH, they will most likely get out of sync with C++16.
> 
> Attached is a new patch (which replaces the previous one) which both fixes the above bug PR10453 and
> contains the (updated) test. I ran the clang test suite on my local machine, and it passed.
> 
> Please let me know what you think!

I've committed this as r135857, with a note that we don't yet implement DR899. Thanks!

	- Doug



More information about the cfe-commits mailing list