[cfe-commits] r135822 - in /cfe/trunk: include/clang/Basic/DiagnosticLexKinds.td test/Lexer/newline-eof.c

[Anna Zaks]

On Jul 22, 2011, at 5:25 PM, Douglas Gregor wrote:

> 
> On Jul 22, 2011, at 4:08 PM, Anna Zaks wrote:
> 
>> Author: zaks
>> Date: Fri Jul 22 18:08:19 2011
>> New Revision: 135822
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=135822&view=rev
>> Log:
>> Expose no newline at end of file warning under Wnewline-eof flag.
>> 
>> Added:
>>   cfe/trunk/test/Lexer/newline-eof.c
>> Modified:
>>   cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
>> 
>> Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td?rev=135822&r1=135821&r2=135822&view=diff
>> ==============================================================================
>> --- cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td Fri Jul 22 18:08:19 2011
>> @@ -38,7 +38,8 @@
>> def ext_bcpl_comment : Extension<
>>  "// comments are not allowed in this language">,
>>  InGroup<Comment>;
>> -def ext_no_newline_eof : Extension<"no newline at end of file">;
>> +def ext_no_newline_eof : Extension<"no newline at end of file">, 
>> +  InGroup<DiagGroup<"newline-eof">>;
>> def ext_backslash_newline_eof : Extension<"backslash-newline at end of file">;
> 
> It seems that ext_backslash_newline_eof should be in the same group?
> 

Done. Thanks. 
Though looks like we never generate the warning.

> 	- Doug