[cfe-commits] r135577 - in /cfe/trunk: include/clang/AST/ include/clang/Analysis/ include/clang/Analysis/Analyses/ include/clang/Basic/ include/clang/CodeGen/ include/clang/Driver/ include/clang/Frontend/ include/clang/Index/ include/clang/Parse/

[Chris Lattner]

On Jul 22, 2011, at 11:58 AM, Mulder, Jonathan wrote:

> Hi Chris,
> 
> This may be a silly question, but is there a reason why these changes were restricted to the header files? Or is it just that you haven't gotten around to making the changes in the .cpp files?

Um, that looks like a 'find' failure. I certainly intended .cpp files to be changed as well, I'll take care of that.

> Also, I notice that there are still some forward declarations of raw_ostream in some header files, for instance "include/clang/AST/PrettyPrinter.h". Are these left as in-file forward declarations versus including "LLVM.h" because the utility of leaving the forward declaration in-file and tying out the using statement versus including "LLVM.h" isn't sufficient for being able to change one case of "llvm::raw_stream" to "raw_ostream" in the header file? Or is this - like the last question - just a case of not having gotten here yet? Or have I just completely missed the boat here? :)

These I missed, if you'd like to tackle them, I'd appreciate it!  Thanks,

-Chris