[cfe-commits] PATCH #2 for "[sema++] clang should give a fixit for */& mismatch"

[Anna Zaks]

Attached are 3 patches that add more support for adding */& mismatch fixits. In particular, C function parameters would get handled as well as assignments in general.

1) In the first patch, I refactored most of the fixit generation functionality out of SemaOverload and provided a simple conversion checking function. This patch also includes a bug fix - the range for FixItHint::CreateRemoval was not specified correctly.


2) This one adds fixit generation to the  Sema::DiagnoseAssignmentResult().


3) Test the fixits generated as a result of  patch #2.


Not done:
ObjectiveC requires more testing. 
We might be able to use the factored out code to insert the fixit generation in places other then overloading and DiagnoseAssignmentResult().
ConversionFixItGenerator::CompareTypesSimple() could be improved.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/7d323929/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deref_addof_refactor.diff
Type: application/octet-stream
Size: 18307 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/7d323929/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/7d323929/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deref_addof_assign.diff
Type: application/octet-stream
Size: 6004 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/7d323929/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/7d323929/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deref_addof_assign_tests.diff
Type: application/octet-stream
Size: 3511 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/7d323929/attachment-0002.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/7d323929/attachment-0003.html>