[cfe-commits] r135502 - /cfe/trunk/lib/Basic/Targets.cpp

Chad Rosier mcrosier at apple.com
Tue Jul 19 12:47:22 PDT 2011


On Jul 19, 2011, at 12:42 PM, Eric Christopher wrote:

> 
> On Jul 19, 2011, at 12:36 PM, Chad Rosier wrote:
> 
>> +  } else if (PlatformName == "win32") {
>> +    // Due to option -ccc-host-triple arch-pc-win32-macho.
>> +    // Don't emit __ENVIRONMENT_XX_OS_VERSION_MIN_REQUIRED__ as we're generating
>> +    // code for Win32 ABI.
>>   } else {
> 
> An empty else if conditional is a little icky. Is it possible to rework the surrounding code to change the conditions here so we can avoid that?

Anything is possible. :)  I'll see what I can do.

 Chad

> -eric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110719/45e37cf7/attachment.html>


More information about the cfe-commits mailing list