[cfe-commits] [PATCH] Define DiagnosticBuilder<<APValue (issue4749047)

[Chris Lattner]

On Jul 18, 2011, at 12:09 AM, Jeffrey Yasskin wrote:

> On Sun, Jul 17, 2011 at 5:49 PM, Chris Lattner <clattner at apple.com> wrote:
>> 
>> On Jul 17, 2011, at 2:41 PM, jyasskin at gmail.com wrote:
>> 
>>> Reviewers: cfe-commits_cs.uiuc.edu,
>>> 
>>> Message:
>>> Initial diff at
>>> http://codereview.appspot.com/download/issue4749047_1.diff.
>>> 
>>> I haven't tested the makefile yet.
>>> 
>>> Description:
>>> Define DiagnosticBuilder<<APValue so it's easy to include APValues in
>>> diagnostics.  This is likely to get more important as generalized
>>> constant expressions get implemented.
>> 
>> Please send patches to the list, not links to an external review site.
> 
> Whoops, sorry, I mis-remembered the right way to do this.
> 
>> Why is WriteShortAPValueToStream templated?  Please convert it to always take a raw_ostream and handle the builder case outside the recursive call.

LGTM, please apply, thanks!

-Chris