[cfe-commits] r135222 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/SemaCXX/expressions.cpp

Chandler Carruth chandlerc at google.com
Thu Jul 14 17:19:34 PDT 2011


On Thu, Jul 14, 2011 at 5:04 PM, Douglas Gregor <dgregor at apple.com> wrote:

> IMO, the right approach would be to suppress this warning when the constant
> value itself was instantiated from something... although that's rather
> trickier to implement.


I don't disagree with your premise.... but it does seem much trickier to
implement. We don't have the nice type sugar in non-types to indicate that
substitution took place. Is it worth adding that for this? Are there other
good reasons to add it?

(Also, this patch seems a strict improvement, and we can add the refined
checking you're mentioning as a second step? I'd like to avoid the false
positives we were seeing with the previous incarnation)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110714/f51e5a93/attachment.html>


More information about the cfe-commits mailing list