[cfe-commits] [cfe-dev] small Mac OS lib++ fixes

Sean Hunt scshunt at csclub.uwaterloo.ca
Wed Jul 13 13:42:48 PDT 2011


On 11-07-13 02:03 AM, Toralf Niebuhr wrote:
> Hi,
>
> these are just two small patches fixing the libc++ build for Mac OS X.
>
> The first patch replaces an "#ifndef LIBCPP_STABLE_APPLE_ABI" with "#ifdef LIBCPP_STABLE_APPLE_ABI".
> This is probably a copy and paste error as it's usually used with "#ifndef"

Yes, thanks. I'll make sure to apply this separately.

> The second patch replaces "__funcs()" with "func()". The underscore calls are encapsulated with the calls without underscores in the "locale" header.

The __func() calls are necessary, as the corresponding non-underscore 
functions are only extensions and not present on some platforms. The 
functions in the headers have underscores because the names are nor 
reserved and thus to work on every platform they must use reserved 
identifiers.

The functions themselves are marked to always be inlined so there ought 
to be no noticeable difference in compilation.

Sean



More information about the cfe-commits mailing list