[cfe-commits] r135001 - in /cfe/trunk: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/Sema/SemaObjCProperty.cpp test/SemaObjCXX/property-type-mismatch.mm

[jahanian]

On Jul 12, 2011, at 3:59 PM, Eli Friedman wrote:

> On Tue, Jul 12, 2011 at 3:54 PM, jahanian <fjahanian at apple.com> wrote:
> 
> Ancient history, from before we had proper C++ semantics.  At least in
> the regression tests, the only use I can find is the test you just
> committed.  It'd be a good idea to add an assertion at the top of
> mergeTypes.

Too risky. It might be called in cases, where caller has ruled out anything but c type. 
Cannot assert without an audit.

> 
>> Properties are in the domain of objective-c. So, I
>> doubt any c++ specific type
>> can trigger an assert and be usable as a property type. But, I can be
>> convinced with an example.
> 
> class CC;
> @protocol P1;
> @interface NSObject
> @end
> @interface A : NSObject
> @property (assign) int CC::* prop;
> @end
> @protocol P2 <P1>
> @end
> @interface B : A
> @property (assign) long CC::* prop;
> @end

Thanks for the example. Reverted in r135010.

- fariborz

> 
> -Eli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110712/232127f8/attachment.html>